FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.3.8

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
415 47 0 0

Files

Class Bugs
org.sat4j.core.Vec 3
org.sat4j.core.VecInt 5
org.sat4j.minisat.constraints.cnf.Lits 1
org.sat4j.minisat.constraints.cnf.UnitClauses 1
org.sat4j.minisat.core.Heap 1
org.sat4j.minisat.core.Pair 1
org.sat4j.minisat.core.Solver 9
org.sat4j.minisat.core.Solver$2 1
org.sat4j.minisat.core.Solver$3 1
org.sat4j.minisat.core.Solver$4 1
org.sat4j.minisat.core.Solver$5 1
org.sat4j.minisat.core.Solver$7 1
org.sat4j.minisat.learning.ActiveLearning 1
org.sat4j.minisat.learning.LimitedLearning 1
org.sat4j.minisat.learning.MiniSATLearning 1
org.sat4j.opt.AbstractSelectorVariablesDecorator 1
org.sat4j.opt.MaxSatDecorator 1
org.sat4j.opt.MinOneDecorator 3
org.sat4j.reader.EfficientScanner 1
org.sat4j.reader.LecteurDimacs 1
org.sat4j.tools.ConflictLevelTracing 1
org.sat4j.tools.DecisionLevelTracing 1
org.sat4j.tools.DecisionTracing 1
org.sat4j.tools.DotSearchTracing 1
org.sat4j.tools.LearnedClauseSizeTracing 1
org.sat4j.tools.Minimal4CardinalityModel 1
org.sat4j.tools.Minimal4InclusionModel 1
org.sat4j.tools.TextOutputTracing 1
org.sat4j.tools.xplain.Pair 2
org.sat4j.tools.xplain.Xplain 1

org.sat4j.core.Vec

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.sat4j.specs.IVec<T> to org.sat4j.core.Vec in org.sat4j.core.Vec.copyTo(IVec) STYLE BC_UNCONFIRMED_CAST 286 Low
org.sat4j.core.Vec.toArray() may expose internal representation by returning Vec.myarray MALICIOUS_CODE EI_EXPOSE_REP 318 Medium
new org.sat4j.core.Vec(Object[]) may expose internal representation by storing an externally mutable object into Vec.myarray MALICIOUS_CODE EI_EXPOSE_REP2 86 Medium

org.sat4j.core.VecInt

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.copyTo(IVecInt) STYLE BC_UNCONFIRMED_CAST 365 Low
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.moveTo2(IVecInt) STYLE BC_UNCONFIRMED_CAST 389 Low
Unchecked/unconfirmed cast from org.sat4j.specs.IVecInt to org.sat4j.core.VecInt in org.sat4j.core.VecInt.pushAll(IVecInt) STYLE BC_UNCONFIRMED_CAST 601 Low
org.sat4j.core.VecInt.toArray() may expose internal representation by returning VecInt.myarray MALICIOUS_CODE EI_EXPOSE_REP 654 Medium
new org.sat4j.core.VecInt(int[]) may expose internal representation by storing an externally mutable object into VecInt.myarray MALICIOUS_CODE EI_EXPOSE_REP2 224 Medium

org.sat4j.minisat.constraints.cnf.Lits

Bug Category Details Line Priority
Class org.sat4j.minisat.constraints.cnf.Lits defines non-transient non-serializable instance field reason BAD_PRACTICE SE_BAD_FIELD Not available Low

org.sat4j.minisat.constraints.cnf.UnitClauses

Bug Category Details Line Priority
Class org.sat4j.minisat.constraints.cnf.UnitClauses is final but declares protected field org.sat4j.minisat.constraints.cnf.UnitClauses.literals STYLE CI_CONFUSED_INHERITANCE Not available Low

org.sat4j.minisat.core.Heap

Bug Category Details Line Priority
new org.sat4j.minisat.core.Heap(double[]) may expose internal representation by storing an externally mutable object into Heap.activity MALICIOUS_CODE EI_EXPOSE_REP2 102 Medium

org.sat4j.minisat.core.Pair

Bug Category Details Line Priority
Class org.sat4j.minisat.core.Pair defines non-transient non-serializable instance field reason BAD_PRACTICE SE_BAD_FIELD Not available Low

org.sat4j.minisat.core.Solver

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.sat4j.specs.IConstr to org.sat4j.minisat.core.Constr in org.sat4j.minisat.core.Solver.removeConstr(IConstr) STYLE BC_UNCONFIRMED_CAST 343 Low
Unchecked/unconfirmed cast from org.sat4j.specs.IConstr to org.sat4j.minisat.core.Constr in org.sat4j.minisat.core.Solver.removeSubsumedConstr(IConstr) STYLE BC_UNCONFIRMED_CAST 364 Low
org.sat4j.minisat.core.Solver.reduceDB() forces garbage collection; extremely dubious except in benchmarking code PERFORMANCE DM_GC 1081 High
Should org.sat4j.minisat.core.Solver.findModel() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1649 Low
Should org.sat4j.minisat.core.Solver.findModel(IVecInt) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 1658 Low
Exception is caught when Exception is not thrown in org.sat4j.minisat.core.Solver.setSimplifier(String) STYLE REC_CATCH_EXCEPTION 679 Low
Class org.sat4j.minisat.core.Solver defines non-transient non-serializable instance field constrTypes BAD_PRACTICE SE_BAD_FIELD Not available Low
Class org.sat4j.minisat.core.Solver defines non-transient non-serializable instance field order BAD_PRACTICE SE_BAD_FIELD Not available Low
Switch statement found in org.sat4j.minisat.core.Solver.learn(Constr) where default case is missing STYLE SF_SWITCH_NO_DEFAULT 310-315 Low

org.sat4j.minisat.core.Solver$2

Bug Category Details Line Priority
org.sat4j.minisat.core.Solver$2 is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1-642 Low

org.sat4j.minisat.core.Solver$3

Bug Category Details Line Priority
org.sat4j.minisat.core.Solver$3 is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1-659 Low

org.sat4j.minisat.core.Solver$4

Bug Category Details Line Priority
org.sat4j.minisat.core.Solver$4 is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1-1213 Low

org.sat4j.minisat.core.Solver$5

Bug Category Details Line Priority
org.sat4j.minisat.core.Solver$5 is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1-1305 Low

org.sat4j.minisat.core.Solver$7

Bug Category Details Line Priority
org.sat4j.minisat.core.Solver$7 is serializable and an inner class BAD_PRACTICE SE_INNER_CLASS 1-1410 Low

org.sat4j.minisat.learning.ActiveLearning

Bug Category Details Line Priority
Class org.sat4j.minisat.learning.ActiveLearning defines non-transient non-serializable instance field order BAD_PRACTICE SE_BAD_FIELD Not available Low

org.sat4j.minisat.learning.LimitedLearning

Bug Category Details Line Priority
LimitedLearning.stats not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low

org.sat4j.minisat.learning.MiniSATLearning

Bug Category Details Line Priority
MiniSATLearning.dsf not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low

org.sat4j.opt.AbstractSelectorVariablesDecorator

Bug Category Details Line Priority
org.sat4j.opt.AbstractSelectorVariablesDecorator.model() may expose internal representation by returning AbstractSelectorVariablesDecorator.prevmodel MALICIOUS_CODE EI_EXPOSE_REP 131 Medium

org.sat4j.opt.MaxSatDecorator

Bug Category Details Line Priority
Class org.sat4j.opt.MaxSatDecorator defines non-transient non-serializable instance field prevConstr BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.sat4j.opt.MinOneDecorator

Bug Category Details Line Priority
org.sat4j.opt.MinOneDecorator.model() may expose internal representation by returning MinOneDecorator.prevmodel MALICIOUS_CODE EI_EXPOSE_REP 123 Medium
Class org.sat4j.opt.MinOneDecorator defines non-transient non-serializable instance field previousConstr BAD_PRACTICE SE_BAD_FIELD Not available Medium
MinOneDecorator.prevmodel not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low

org.sat4j.reader.EfficientScanner

Bug Category Details Line Priority
The field org.sat4j.reader.EfficientScanner.in is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available Low

org.sat4j.reader.LecteurDimacs

Bug Category Details Line Priority
LecteurDimacs.in not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available Low

org.sat4j.tools.ConflictLevelTracing

Bug Category Details Line Priority
Class org.sat4j.tools.ConflictLevelTracing defines non-transient non-serializable instance field out BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.sat4j.tools.DecisionLevelTracing

Bug Category Details Line Priority
Class org.sat4j.tools.DecisionLevelTracing defines non-transient non-serializable instance field out BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.sat4j.tools.DecisionTracing

Bug Category Details Line Priority
Class org.sat4j.tools.DecisionTracing defines non-transient non-serializable instance field out BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.sat4j.tools.DotSearchTracing

Bug Category Details Line Priority
Class org.sat4j.tools.DotSearchTracing defines non-transient non-serializable instance field mapping BAD_PRACTICE SE_BAD_FIELD Not available Low

org.sat4j.tools.LearnedClauseSizeTracing

Bug Category Details Line Priority
Class org.sat4j.tools.LearnedClauseSizeTracing defines non-transient non-serializable instance field out BAD_PRACTICE SE_BAD_FIELD Not available Medium

org.sat4j.tools.Minimal4CardinalityModel

Bug Category Details Line Priority
Dead store to prevmodel in org.sat4j.tools.Minimal4CardinalityModel.model() STYLE DLS_DEAD_LOCAL_STORE 63 Low

org.sat4j.tools.Minimal4InclusionModel

Bug Category Details Line Priority
Dead store to prevmodel in org.sat4j.tools.Minimal4InclusionModel.model() STYLE DLS_DEAD_LOCAL_STORE 68 Low

org.sat4j.tools.TextOutputTracing

Bug Category Details Line Priority
Class org.sat4j.tools.TextOutputTracing defines non-transient non-serializable instance field mapping BAD_PRACTICE SE_BAD_FIELD Not available Low

org.sat4j.tools.xplain.Pair

Bug Category Details Line Priority
org.sat4j.tools.xplain.Pair defines compareTo(Pair) and uses Object.equals() BAD_PRACTICE EQ_COMPARETO_USE_OBJECT_EQUALS 46-51 Medium
Test for floating point equality in org.sat4j.tools.xplain.Pair.compareTo(Pair) STYLE FE_FLOATING_POINT_EQUALITY 48 Low

org.sat4j.tools.xplain.Xplain

Bug Category Details Line Priority
Should org.sat4j.tools.xplain.Xplain.model() return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 243 Low